Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21740] Register and propagate MonitorService status type object #5253

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Sep 23, 2024

Description

All statistics types are currently being registered and propagated (via TypeLookupService), except the type of _fastdds_monitor_service_status topic (MonitorServiceStatusData). This PR corrects that behaviour.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanlofer-eprosima juanlofer-eprosima changed the title Register and propagate MonitorService status type object [21740] Register and propagate MonitorService status type object Sep 23, 2024
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima September 23, 2024 09:27
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 23, 2024
@Mario-DL Mario-DL self-requested a review September 23, 2024 09:28
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL
Copy link
Member

In principle we should not backport this since it is related to the new XTypes refactor introduced in 3.x

@juanlofer-eprosima juanlofer-eprosima merged commit 0bf7481 into master Sep 24, 2024
17 of 31 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the bugfix/propagate-monitor-status-typeobj branch September 24, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants